iraf.net

I noticed some minor bugs and inconsistencies in the handling of certain things in [b:030987ae51]daophot[/b:030987ae51] package that should be easy to fix.1) The [b:030987ae51]phot[/b:030987ae51] and [b:030987ae51]pstselect[/b:030987ae51] tasks' output files incorrectly use "scaleunit" as the descriptor of CLEAN rather than "switch". Actually this seems to affect all the phot tasks in the [b:030987ae51]apphot[/b:030987ae51] package too ([b:030987ae51]wphot[/b:030987ae51], etc.) A bug in every IRAF photometry file ever produced! :wink:2) The [b:030987ae51]daofind[/b:030987ae51] task's output coo file has FWHMPSF listed twice in the headers. I'm not sure how the subsequent tasks read the headers. Is the second one needed? Seems like it should be removed.3) IMAGE is described by [b:030987ae51]pstselect[/b:030987ae51] in the headers of the output file (usually .pst.1) as "name" when it should be "imagename" to match the [b:030987ae51]daofind[/b:030987ae51] (coo), [b:030987ae51]phot[/b:030987ae51] (mag), [b:030987ae51]psf[/b:030987ae51] (pst.2), and [b:030987ae51]allstar[/b:030987ae51] (als) tasks.4) This next one is probably an apphot vs daophot thing that can't be fixed for history. IFILTER is described "name" in the mag file of [b:030987ae51]phot[/b:030987ae51] while the [b:030987ae51]pstselect[/b:030987ae51] (pst.1), [b:030987ae51]psf[/b:030987ae51] (pst.2), and [b:030987ae51]allstar[/b:030987ae51] (als) tasks call it "filter". Also SCALE is described as "units" by [b:030987ae51]daofind[/b:030987ae51], [b:030987ae51]phot[/b:030987ae51], and [b:030987ae51]pstsel[/b:030987ae51] but "units/pix" by [b:030987ae51]psf[/b:030987ae51] and [b:030987ae51]allstar[/b:030987ae51]. I do think there's value in having it be "units/pix" but this would entail checking and changing wphot and so on. In any case, [b:030987ae51]pstsel[/b:030987ae51] should be using the "units/pix" daophot style description.Jason

Hi Jason,[quote:8b554de0ec]
1) The phot and pstselect tasks' output files incorrectly use "scaleunit" as the descriptor of CLEAN rather than "switch". Actually this seems to affect all the phot tasks in the apphot package too (wphot, etc.) A bug in every IRAF photometry file ever produced! [/quote:8b554de0ec]Fixed for the next release.[quote:8b554de0ec]2) The daofind task's output coo file has FWHMPSF listed twice in the headers. I'm not sure how the subsequent tasks read the headers. Is the second one needed? Seems like it should be removed.[/quote:8b554de0ec]I left this alone for now. The first grouping is a general set of APPHOT parameters that is common to most output files, the second set are params specific to the daofind task. These are printed by different procedures and I'd have to do some testing to be sure I wasn't eliminating the value entirely for some other task. For now, it appears harmless, if redundant.[quote:8b554de0ec]3) IMAGE is described by pstselect in the headers of the output file (usually .pst.1) as "name" when it should be "imagename" to match the daofind (coo), phot (mag), psf (pst.2), and allstar (als) tasks.[/quote:8b554de0ec]Fixed for the next release.[quote:8b554de0ec]4) This next one is probably an apphot vs daophot thing that can't be fixed for history. IFILTER is described "name" in the mag file of phot while the pstselect (pst.1), psf (pst.2), and allstar (als) tasks call it "filter". Also SCALE is described as "units" by daofind, phot, and pstsel but "units/pix" by psf and allstar. I do think there's value in having it be "units/pix" but this would entail checking and changing wphot and so on. In any case, pstsel should be using the "units/pix" daophot style description. [/quote:8b554de0ec]Again left this one alone. As far as I can tell, the PSTSEL task should already be printing the "units/pix" that you suggest so I'm not sure what the last comment refers to.Cheers,
-Mike