Welcome to iraf.net Saturday, December 16 2017 @ 01:42 AM GMT


 Forum Index > Help Desk > General IRAF New Topic Post Reply
 Numerical Recipes code
First | Previous | 1 2 | Next | Last
   
olebole
 04/26/2017 06:45AM  
++++-
Regular Member

Status: offline


Registered: 05/01/2014
Posts: 83
Quote by: fitz

One question/remark: Is there a reason why you encoded the version number in the repository name? This will not match anymore once there is a new release out.


Seriously? The original plan was to essentially migrate the FTP archive to repos, preserving the history of platforms and branches for different versions, but that takes time. At some later time, or not, that level of organization can be applied, but for now just shut up and enjoy your "official" repo.



So once there is a 2.17 (or you finished the complete history), you will create a new repository and migrate all open issues and pull requests there? Sounds that you create much more work for yourself than necessary. And it will confuse the contributors.

 
Profile Email Website
 Quote
fitz
 04/26/2017 06:51AM  
AAAAA
Admin

Status: offline


Registered: 09/30/2005
Posts: 3989
There is no guarantee there will actually be a v2.17 release at this stage. But of course you're right and if you prefer I can delete the repos until such time as this can be done properly.

 
Profile Email
 Quote
olebole
 11/16/2017 08:16PM  
++++-
Regular Member

Status: offline


Registered: 05/01/2014
Posts: 83
Fitz wrote:
Likewise, I acknowledge the NR license statement problems to be fixed, and I look forward to the PR that shows a code replacement for the MR code works the same way


To make you happy here: Pull request #37 replaces all problematic code that was taken from Numerical Recipes. The tests are part of pull request #36, specifically the file numrecipes.md. I cross-checked my own list of problematic files with the one used by STSCI to not miss anything; however if you know of more, let me know. And see also the discussion in the pull request about a few files not replaced. Please respond there if needed. Details about the implementation should also be discussed there.

So, how do we proceed now?

 
Profile Email Website
 Quote
lupinix
 11/17/2017 09:27AM  
+----
Newbie

Status: offline


Registered: 09/22/2017
Posts: 2
Quote by: olebole

Fitz wrote:

Likewise, I acknowledge the NR license statement problems to be fixed, and I look forward to the PR that shows a code replacement for the MR code works the same way


To make you happy here: Pull request #37 replaces all problematic code that was taken from Numerical Recipes. The tests are part of pull request #36, specifically the file numrecipes.md. I cross-checked my own list of problematic files with the one used by STSCI to not miss anything; however if you know of more, let me know. And see also the discussion in the pull request about a few files not replaced. Please respond there if needed. Details about the implementation should also be discussed there.

So, how do we proceed now?



@olebole: Thank you very much! This his a huge step for the inclusion of IRAF in Linux distributions, started to work on that now for Fedora.

 
Profile Email
 Quote
   
First | Previous | 1 2 | Next | Last
Content generated in: 0.11 seconds
New Topic Post Reply

Normal Topic Normal Topic
Sticky Topic Sticky Topic
Locked Topic Locked Topic
New Post New Post
Sticky Topic W/ New Post Sticky Topic W/ New Post
Locked Topic W/ New Post Locked Topic W/ New Post
View Anonymous Posts 
Anonymous users can post 
Filtered HTML Allowed 
Censored Content 
dog allergies remedies cialis 20 mg chilblain remedies


Privacy Policy
Terms of Use

User Functions

Login